Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace svelte-preprocess with barebones TS preprocessor #2452

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 31, 2024

Removes the need for a dependency on svelte-preprocess in svelte-language-server, since that was all we used it for. Also tightens up the warning filter to account for situations where those could be wrong.

closes:

@jasonlyu123 any situation I'm not correctly antipicating here which would make this a bad change? The only cases I see where this could have any change in behavior compared to before is if you're opening a Svelte file with lang="ts" and no config and...

  • using import statements that don't adhere to verbatimModuleSyntax, but even then I think it will not make a difference because Svelte does not care which imports are left in the file.
  • using decorators, because they are not transpiled and lead to a compiler error, but then the "filter out this error" logic should kick in, so it's fine

Removes the need for a dependency on svelte-preprocess in svelte-language-server, since that was all we used it for.

closes:
- #1683 and #1259, because the situation no longer arises (because we no longer have svelte-preprocess inside the VS Code extension)
- #2391
Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can't think of another situation either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants